Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lang] Add parameter 'order' to specify layout for scalar, vector, matrix fields #5617

Merged
merged 5 commits into from
Aug 3, 2022
Merged

[Lang] Add parameter 'order' to specify layout for scalar, vector, matrix fields #5617

merged 5 commits into from
Aug 3, 2022

Conversation

strongoier
Copy link
Contributor

Related issue = #5491

This PR adds support for the following syntax as described in #5491:

a = ti.field(ti.i32, shape=(128, 64, 32), order='kij')
b = ti.Vector.field(3, ti.i32, shape=(128, 64), order='ji', layout=ti.Layout.SOA)

@netlify
Copy link

netlify bot commented Aug 3, 2022 •
edited
Loading

✅ Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 62ca534
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/62ea3577f9b7e00008f3e761
😎 Deploy Preview https://deploy-preview-5617--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@taichi-gardener taichi-gardener added this to In progress in Lang Features & Python Aug 3, 2022
@strongoier strongoier added this to the Taichi v1.1.0 milestone Aug 3, 2022
k-ye
k-ye approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

python/taichi/lang/matrix.py Outdated Show resolved Hide resolved
yuanming-hu
yuanming-hu approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job! LGTM!

@ailzhang ailzhang merged commit 9d072a2 into taichi-dev:master Aug 3, 2022
Lang Features & Python automation moved this from In progress to Done Aug 3, 2022
@strongoier strongoier deleted the add-order branch August 4, 2022 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuanming-hu yuanming-hu yuanming-hu approved these changes

@k-ye k-ye k-ye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Lang Features & Python
Done
Milestone
Taichi v1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@strongoier @yuanming-hu @k-ye @ailzhang